fix: use server upgrade event to access head buffer (#12)#14
Merged
Conversation
Change API from middleware pattern to setup function to fix WebSocket connections timing out on HTTPS servers. The middleware pattern couldn't access the upgrade head buffer, causing Node.js to not properly recognize WebSocket upgrades. BREAKING CHANGE: API changed from `app.use(tinyws())` to `tinyws(app, server)` - Add paths option to restrict WebSocket handling to specific routes - Export TinyWSOptions interface for TypeScript users - Update examples and documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix YAML indentation bug in main.yml - Run CI on all pushes/PRs, not just master - Add lint step to CI - Update package.json scripts to use biome and bun test - Add release.yml for npm publishing on git tags Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
v1rtl
force-pushed
the
fix/websocket-upgrade-head-buffer
branch
2 times, most recently
from
2c20e0d to
d04439a
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
v1rtl
force-pushed
the
fix/websocket-upgrade-head-buffer
branch
from
d04439a to
85d29b8
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
v1rtl
force-pushed
the
fix/websocket-upgrade-head-buffer
branch
from
4dd5ffb to
6bee045
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change API from middleware pattern to setup function to fix WebSocket connections timing out on HTTPS servers. The middleware pattern couldn't access the upgrade head buffer, causing Node.js to not properly recognize WebSocket upgrades.
BREAKING CHANGE: API changed from
app.use(tinyws())totinyws(app, server)